HMG 2.5.5

[gfilatov]

Excuse me but a new Image ComboBox is not work at Win98 (a such control is not displayed).
The ComboBox control without an Image clause still works OK.

Please try removing comment slashes '//' in the lines 195 and 196 of c_combo.c file.

Roberto,

Thanks for prompt reply!
The Imaged ComboBox works now at Win98

[Roberto Lopez]

Excuse me but a new Image ComboBox is not work at Win98 (a such control is not displayed).
The ComboBox control without an Image clause still works OK.

Please try removing comment slashes '//' in the lines 195 and 196 of c_combo.c file.

Roberto,

Thanks for prompt reply!
The Imaged ComboBox works now at Win98

Thanks!

I've forgot to uncomment that lines

I'll publish the fix in the next build.

Regards,

Roberto.

[gfilatov]

I've forgot to uncomment that lines

I'll publish the fix in the next build.

Hello Roberto,

There are a more library code's improvements:

1) look at h_button.prg for the following condition:

Code: Select all

...
	if (.Not. IsAppThemed()) 

		aRet := InitImageButton ( ParentForm, Caption, 0, x, y, w, h, image , flat , notrans, invisible, notabstop , .F. )

	else

		aRet := InitImageButton ( ParentForm, Caption, 0, x, y, w, h, image , flat , notrans, invisible, notabstop , .T. )

	endif

Why not to replace it with one code's string:

Code: Select all

		aRet := InitImageButton ( ParentForm, Caption, 0, x, y, w, h, image , flat , notrans, invisible, notabstop , IsAppThemed() )

2) look at h_windows.prg for function IsAppThemed():

Code: Select all

*------------------------------------------------------------------------------*
Function IsAppThemed() 
*------------------------------------------------------------------------------*
local uResult 
Local nVersion 

	nVersion := WINMAJORVERSIONNUMBER() + ( WINMINORVERSIONNUMBER() / 10 )

	If nVersion >= 5.1
...

Why not to replace it with one code's string:

Code: Select all

...
	If IsWinXPorLater()
...

where

Code: Select all

*------------------------------------------------------------------------------*
Function IsWinXPorLater()
*------------------------------------------------------------------------------*
Local nVersion 

	nVersion := WINMAJORVERSIONNUMBER() + ( WINMINORVERSIONNUMBER() / 10 )

Return ( nVersion >= 5.1 )

Or is better as C-level function

Code: Select all

HB_FUNC( ISWINXPORLATER )
{
  OSVERSIONINFO osvi;

  osvi.dwOSVersionInfoSize = sizeof( OSVERSIONINFO );
  GetVersionEx ( ( OSVERSIONINFO * ) &osvi );

  hb_retl( osvi.dwPlatformId == VER_PLATFORM_WIN32_NT
        && ((osvi.dwMajorVersion == 5 && osvi.dwMinorVersion > 0) || 
		(osvi.dwMajorVersion > 5)) );
}

Just my two cents...

[Roberto Lopez]

There are a more library code's improvements:
<...>Just my two cents...

Well... I've only took a brief look at your suggestions, but I'm afraid that you are right

When I'm 'fighting' against Windows API, usually I write some 'silly' code, beacuse I'm focused on make that **** 'thing' working right.

When that 'thing' finally works I do some 'clean and sweep', but sometimes I've forgot and sometimes I'm simply 'lazy'

Regards,

Roberto.

[Roberto Lopez]

There are a more library code's improvements:
<...>Just my two cents...

Well... I've only took a brief look at your suggestions, but I'm afraid that you are right

Anyway... Had you heard about "It's working fine, don't touch it" ?



Regards,

Roberto.

[gfilatov]

Anyway... Had you heard about "It's working fine, don't touch it" ?

Roberto,

Yes, of course!

[Rathinagiri]

It is nice to see two giants talking about simplified programming.

[Roberto Lopez]

It is nice to see two giants talking about simplified programming.

My weight has augmented lately... It's winter here... and... you know... one tends to eat more... but 'giant' may be a little exaggerated

Regards,

Roberto.

[Rathinagiri]

In that case, I would recall the giants philosophy.